Add Check for ´err´ #9716
Merged
Add Check for ´err´ #9716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwoulfe
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
@nielslyngsoe makes sense. Would be good to start using optional chaining for these cases (it's supported in all evergreen browsers, and can be polyfilled for older browsers if needed).
nathanwoulfe
added
release/8.12.0
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this fix(#9690) I sometimes get JS error for
errbeing undefined.This PR add a check for that.
To reproduce: make a DocType with Mandatory Media Picker, try to save without a media picked.