Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links.yml #19665

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Fix links.yml #19665

merged 5 commits into from
Mar 12, 2025

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Mar 12, 2025

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Minor update to GitHub Actions workflow for consistency and reliability.

📊 Key Changes

  • Updated a conditional statement in the links.yml workflow file to use single quotes instead of double quotes.

🎯 Purpose & Impact

  • 🛠 Improved Consistency: Aligns with best practices for YAML formatting, ensuring uniformity across the codebase.
  • Enhanced Reliability: Reduces potential parsing issues in GitHub Actions, leading to smoother workflow execution.

This is a small but meaningful improvement to maintain high-quality development standards. 🚀

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Mar 12, 2025
@UltralyticsAssistant
Copy link
Member

👋 Hello @glenn-jocher, thank you for submitting an ultralytics/ultralytics 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/ultralytics main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

P.S. This is an automated response to help streamline the review process, but rest assured, an Ultralytics engineer will review your PR and assist you further soon. 😊

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (069473c) to head (149b569).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19665      +/-   ##
==========================================
- Coverage   72.91%   72.88%   -0.04%     
==========================================
  Files         133      133              
  Lines       17728    17728              
==========================================
- Hits        12927    12921       -6     
- Misses       4801     4807       +6     
Flag Coverage Δ
Benchmarks 33.77% <ø> (-0.04%) ⬇️
GPU 37.50% <ø> (ø)
Tests 66.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit fbd6e91 into main Mar 12, 2025
14 of 16 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch March 12, 2025 23:43
@UltralyticsAssistant
Copy link
Member

🎉 PR Merged!

Thank you, @glenn-jocher, for this thoughtful update! 🚀 As Leonardo da Vinci once said, "Details make perfection, and perfection is not a detail." This minor yet impactful improvement to the GitHub Actions workflow exemplifies that philosophy.

By enhancing consistency and reliability, you've helped ensure smoother operations and reinforced the high standards we strive for at Ultralytics. Your dedication to excellence continues to inspire us all. 🙌

Keep shining, and thank you for being an integral part of the Ultralytics journey! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants