Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image count information for COCO-Pose #18395

Merged
merged 6 commits into from
Dec 25, 2024
Merged

Conversation

Y-T-G
Copy link
Collaborator

@Y-T-G Y-T-G commented Dec 25, 2024

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated documentation and dataset configuration for COCO-Pose to reflect accurate image counts across subsets and updated competition links.

📊 Key Changes

  • 📚 Corrected image counts in the COCO-Pose dataset:
    • Train2017: 56,599 images (previously "a portion of 118k").
    • Val2017: 2,346 images (previously "a selection for validation").
  • 🔗 Updated COCO evaluation server link to the newer lisn.upsaclay.fr competition server.
  • 📝 Adjusted coco-pose.yaml configuration file to align with new image counts for training, validation, and testing subsets.

🎯 Purpose & Impact

  • Clarity: Ensures documentation and configuration reflect the actual dataset structure and counts, avoiding confusion for users.
  • 🌐 Updated Links: Redirects users to the correct COCO evaluation platform, enhancing accessibility.
  • 🚀 Improved Usability: Simplifies training process by aligning training configuration with verified data subsets.

These updates enhance the accuracy and usability of the COCO-Pose resources for pose estimation tasks. 🦾

Signed-off-by: Mohammed Yasin <32206511+Y-T-G@users.noreply.github.com>
Signed-off-by: Mohammed Yasin <32206511+Y-T-G@users.noreply.github.com>
Signed-off-by: Mohammed Yasin <32206511+Y-T-G@users.noreply.github.com>
Signed-off-by: Mohammed Yasin <32206511+Y-T-G@users.noreply.github.com>
@UltralyticsAssistant UltralyticsAssistant added documentation Improvements or additions to documentation pose Pose/keypoint estimation models labels Dec 25, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @Y-T-G, thank you for submitting an ultralytics/ultralytics 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and ensure your commit messages are clear and concise.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/ultralytics main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features you are suggesting.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement (CLA) if this is your first Ultralytics PR by stating "I have read the CLA Document and I sign the CLA" in a new comment.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

An Ultralytics engineer will review your PR shortly to provide further feedback or approval. Thank you for contributing to Ultralytics! 🚀

Y-T-G and others added 2 commits December 26, 2024 02:02
Signed-off-by: Mohammed Yasin <32206511+Y-T-G@users.noreply.github.com>
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.88%. Comparing base (3b897a3) to head (791fc7a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18395   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files         129      129           
  Lines       17248    17248           
=======================================
  Hits        12743    12743           
  Misses       4505     4505           
Flag Coverage Δ
Benchmarks 34.94% <ø> (ø)
GPU 38.36% <ø> (ø)
Tests 67.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glenn-jocher glenn-jocher merged commit 3e65fc2 into main Dec 25, 2024
18 checks passed
@glenn-jocher glenn-jocher deleted the coco-pose-docs branch December 25, 2024 18:33
@glenn-jocher
Copy link
Member

@Y-T-G great improvements, nice and quantifiable!

@UltralyticsAssistant
Copy link
Member

🎉 Huge thanks to @Y-T-G for the stellar PR and to @glenn-jocher for the collaboration—your contributions are now merged! 🌟

By refining the COCO-Pose dataset configuration and links, you've helped ensure clarity and usability for the community. As Leonardo da Vinci said, "Simplicity is the ultimate sophistication." This update embodies that wisdom by making complex tasks more accessible and accurate for everyone. 🚀

Your work inspires progress—thank you for helping us shape tools that make a difference! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pose Pose/keypoint estimation models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants