-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced GroundingDataset annotation unpacking speed #18382
Reduced GroundingDataset annotation unpacking speed #18382
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: ultralytics/data/dataset.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18382 +/- ##
==========================================
+ Coverage 73.70% 73.73% +0.03%
==========================================
Files 129 129
Lines 17278 17279 +1
==========================================
+ Hits 12735 12741 +6
+ Misses 4543 4538 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🎉 PR Merged! Huge thanks to @Lornatang for leading this improvement, with valuable insights from @Laughing-q and @glenn-jocher. Your collaborative effort to simplify and refine dataset handling ensures faster, cleaner, and smarter processes for everyone. 🚀✨ As Leonardo da Vinci once said, "Simplicity is the ultimate sophistication." This work embodies that spirit by making the code more elegant and impactful. Your contributions today will ripple out into countless projects, empowering developers and creators alike. Bravo! 🙌 |
Reduce IO latency caused by multiple unpacking when faced with a large number of annotations
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved dataset handling by reorganizing captions for cleaner and more efficient processing. 🛠️
📊 Key Changes
caption = img["caption"]
before using it in label extraction logic.cat_name
) are pulled from captions during annotation processing.🎯 Purpose & Impact