Fix React and Vue NodeView renderers not adding correct selection classes #4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
svenadlung
approved these changes
Sep 15, 2023
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
…sses (ueberdosis#4452) * fix(react): add correct / remove selected class * fix(vue-2): add correct / remove selected class * fix(vue-3): add correct / remove selected class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Fix for an issue that caused node-view elements not having the
.Prosemirror-selectednodeclass as the vanilla nodeViews and normal atom node blocks receive.How did you accomplish your changes
Add according classList modifications to the renderer code.
How have you tested your changes
Locally inside the vue-2, vue-3 and react demos and compared to the vanilla js demo
How can we verify your changes
See above
Checklist