Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node input rule handling #4341

Merged
merged 2 commits into from Aug 18, 2023
Merged

Improve node input rule handling #4341

merged 2 commits into from Aug 18, 2023

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Aug 17, 2023

Please describe your changes

This implements the fix from #3859 by @ngryman – just merged it with the most recent develop branch & made sure nothing broke in the meanwhile.

@bdbch bdbch self-assigned this Aug 17, 2023
@bdbch bdbch requested a review from svenadlung as a code owner August 17, 2023 16:46
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit ae8c22c
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64de4effed26bd00082c44ed
😎 Deploy Preview https://deploy-preview-4341--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

svenadlung
svenadlung previously approved these changes Aug 17, 2023
@rfgamaral
Copy link
Contributor

@bdbch @svenadlung Do you folks think this could be merged soon, and a v2.1.4 released/published?

@bdbch
Copy link
Contributor Author

bdbch commented Aug 18, 2023

Sure thing! Give me 30 minutes and I'll make a new release for this.

@rfgamaral
Copy link
Contributor

Sure thing! Give me 30 minutes and I'll make a new release for this.

No need to be that fast, take your time. 😅

If you want to push some more fixes along with it, be my guest 😁

@bdbch
Copy link
Contributor Author

bdbch commented Aug 18, 2023

Haha no worries! I'll take 1-2 more things into this release and then push it out.

@bdbch bdbch changed the base branch from develop to main August 18, 2023 15:31
@bdbch bdbch dismissed svenadlung’s stale review August 18, 2023 15:31

The base branch was changed.

@bdbch bdbch merged commit ffeefe2 into main Aug 18, 2023
15 checks passed
@bdbch bdbch deleted the fix/nodeInputRule branch August 18, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants