Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(strikethrough): update strikethrough shortcut #4288

Merged
merged 2 commits into from Aug 5, 2023

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Aug 5, 2023

Please describe your changes

This PR changes the shortcut for strikethrough to a more standardized version similar to other apps (Notion, Dropbox Paper).

Now the default shortcut is Mod+Shift+s for MacOS and Ctrl+Shift+s for other operation systems.

See https://defkey.com/search?irq=strikethrough

How did you accomplish your changes

Changed the addKeyboardShortcuts function

How have you tested your changes

Tested them locally on MacOS and Windows.

How can we verify your changes

Check the deployed demo

Remarks

nothing

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

closes #2540

@bdbch bdbch added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Refactor The issue or pullrequest is related to refactoring code labels Aug 5, 2023
@bdbch bdbch self-assigned this Aug 5, 2023
@bdbch bdbch requested a review from svenadlung as a code owner August 5, 2023 00:36
@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit ec0b4a3
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64cd997fbaba0000087b5a0c
😎 Deploy Preview https://deploy-preview-4288--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch merged commit fd35db4 into develop Aug 5, 2023
15 checks passed
@bdbch bdbch deleted the fix/strikethrough-shortcuts branch August 5, 2023 09:38
@Nantris
Copy link
Contributor

Nantris commented Aug 26, 2023

This PR needs to be amended to be case-insensitive like the others (eg bold) This apparently isn't necessary for hotkeys which incorporate Shift


Also the docs seem to have not been updated to reflect the key change: https://tiptap.dev/api/marks/strike#keyboard-shortcuts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Refactor The issue or pullrequest is related to refactoring code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Keyboard shortcut for strikethrough overwrites browser shortcut for switching to right to left language layout
3 participants