Retain existing config when calling configure on Marks and Extensions (attempt 2) #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nholden
force-pushed
the
nholden/retain-config-2
branch
from
d297c06
to
5703ed2
Compare
|
Hey @nholden - sorry for not reviewing this PR earlier. This looks promising – at least I didn't encounter the issues we experienced with the first draft. Do you mind we merge this and bring it into |
svenadlung
approved these changes
Aug 16, 2023
bdbch
approved these changes
Aug 16, 2023
|
Sounds great. Thanks, @bdbch! |
|
can we merge this? |
|
This has already been resolved by #4191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at addressing #3813. My first attempt, #3822, had to be reverted because of issues described in this comment. That comment described a defaultOptions warning that I was able to reproduce in my original approach, and I confirmed it's no longer present in this approach. cc @bdbch
Currently, when you call
.configure()on aMarkorExtension, theMarkorExtensionthat's returned doesn't retain the config from the original.This is a problem for StarterKit. When
Codeis added to an editor added as a standalone extension, an inline code block isexitable. When added as part of StarterKit, an inline code block is notexitablebecause StarterKit callsCode.configure(), blowing away the default config.This PR ensures that when you call
.configure()on aMarkorExtension, theMarkorExtensionthat's returned retains the config from the original.closes #3813