Firmware download improvement #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdr
reviewed
May 20, 2024
fdr
reviewed
May 20, 2024
fdr
reviewed
May 20, 2024
|
It seems like the patches need some squashing or reordering or something, to make each work, or at least, the first two, right? If you adapted this from #1360, don't take anything in it too seriously... It'd also be nice to have a second patch set showing an unwinding of the legacy stuff, to show how much net code we're adding for this. This particular change is more phasing-intensive than program-complexity-intensive. |
enescakir
reviewed
May 20, 2024
See https://github.com/ubicloud/ubicloud/commits/ben/firmware_remove_legacy/ |
byucesoy
reviewed
May 22, 2024
Extend `safe_write_to_file` to either take the content as string or a block producing the content.
The new implementation downloads the firmware from https://github.com/ubicloud/build-edk2-firmware and stores it in `/opt/fw`. As an example, firmware with version 202402 would be located at `/opt/fw/CLOUDHV-202402.fd`. The firmware's SHA-256 digest is verified during the download.
Start to download new firmware in addition to legacy firmware during host preparation. When the legacy firmware has become obsolete, we will stop to download the legacy firmware.
`download-firmware` can be run independent of preparing an entire host to download the new firmware.
Introduce a `download_firmware` Prog that allows to download new firmware versions from the control plane. It depends on the `host/bin/download-firmware` script. A `download_firmware` method added to `VmHost` allows to download new firmware versions to vm hosts, leveraging the newly added Prog.
byucesoy
approved these changes
May 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we add the ability to download firmware from https://github.com/ubicloud/build-edk2-firmware and store it on the host in
/opt/fwas files named 'CLOUDHV-version.fd'. New hosts will start to download the firmware (in addition to legacy firmware) duringprep_host. The PR also adds capabilities to download specified versions to hosts on demand. With this, new firmware versions can be deployed to and enabled for all hosts by performing these steps:download_firmwareon each host to download the new versionrhizome/host/lib/cloud_hypervisor.rbto the new versionIn order to switch from legacy to new firmware, instead of step 2, we need to rename
FIRMWAREtoFIRMWARE_LEGACYandNEW_FIRMWAREtoFIRMWARE, to enable the new firmware for VMs.