Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockGen header comment: trim .exe suffix on Windows #119

Merged
merged 2 commits into from Nov 17, 2023

Conversation

craig65535
Copy link
Contributor

To address #118

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
All committers have signed the CLA.

mockgen/mockgen.go Outdated Show resolved Hide resolved
mockgen/mockgen.go Outdated Show resolved Hide resolved
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@craig65535
Copy link
Contributor Author

@r-hang Are you able to start the workflow on this PR? Thank you!

@craig65535
Copy link
Contributor Author

@tchung1118 Are you able to start the workflow on this PR? Thank you!

Copy link
Contributor

@r-hang r-hang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, lgtm.

@r-hang r-hang merged commit 5b48f95 into uber-go:main Nov 17, 2023
3 checks passed
@craig65535 craig65535 deleted the trim-exe branch November 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants