Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockGen header comment: trim .exe suffix on Windows #119

Merged
merged 2 commits into from
Nov 17, 2023
Merged

MockGen header comment: trim .exe suffix on Windows #119

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4721e4
MockGen header comment: trim .exe suffix on Windows
craig65535 Nov 10, 2023
a8e5672
Checking strings.HasSuffix is redundant
craig65535 Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion mockgen/mockgen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"os/exec"
"path"
"path/filepath"
"runtime"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -316,7 +317,11 @@ func (g *generator) Generate(pkg *model.Package, outputPkgName string, outputPac
g.p("// Generated by this command:")
g.p("//")
// only log the name of the executable, not the full path
g.p("//\t%v", strings.Join(append([]string{filepath.Base(os.Args[0])}, os.Args[1:]...), " "))
name := filepath.Base(os.Args[0])
if runtime.GOOS == "windows" && strings.HasSuffix(name, ".exe") {
craig65535 marked this conversation as resolved.
Show resolved Hide resolved
name = strings.TrimSuffix(name, ".exe")
}
g.p("//\t%v", strings.Join(append([]string{name}, os.Args[1:]...), " "))
g.p("//")

// Get all required imports, and generate unique names for them all.
Expand Down