Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: Enable errcheck, fix failures #1345

Merged
merged 4 commits into from
Sep 6, 2023
Merged

lint: Enable errcheck, fix failures #1345

merged 4 commits into from
Sep 6, 2023

Commits on Sep 2, 2023

  1. lint: Enable errcheck, fix failures 

    This enables linting with errcheck on the repository.
Exclusions were added for functions that are known
to never fail, e.g. all Write methods on Zap's buffer.Buffer.

In attempting to enable exclusions for these functions,
I discovered and fixed a typo in the golangci.yml.
    @abhinav
    abhinav committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    312369b View commit details
    Browse the repository at this point in the history

  2. test(AtomicLevel): Broken ResponseWriter

    @abhinav
    abhinav committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    cb09f36 View commit details
    Browse the repository at this point in the history

  3. test(errArray): Broken ArrayEncoder

    @abhinav
    abhinav committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    da17ca1 View commit details
    Browse the repository at this point in the history

  4. test(CheckedEntry): Reuse detection 

    Add a test for CheckedEntry re-use detection
that logs a message to ErrorOutput
when a CheckedEntry is accidentally reused.
    @abhinav
    abhinav committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    b86843b View commit details
    Browse the repository at this point in the history