Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DPanic fatal in zaptest #1274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make DPanic fatal in zaptest #1274

wants to merge 1 commit into from

Commits on Apr 17, 2023

  1. Make DPanic fatal in zaptest 

    The intention of DPanic is to catch errors that should never happen.
Unless you added zaptest.WrapOptions(zap.Development()), they were
previously silently ignored.

The downside of this change, however, that it's impossible to _disable_
development mode for zaptest logger.
    @WGH-
    WGH- committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    377e39f View commit details
    Browse the repository at this point in the history