Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-minitest from 0.33.0 to 0.34.2 #3314

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps rubocop-minitest from 0.33.0 to 0.34.1.

Release notes

Sourced from rubocop-minitest's releases.

RuboCop Minitest 0.34.1

Bug fixes

  • #281: Fix an error when assigning a value to an object attribute. (@​koic)

RuboCop Minitest 0.34.0 (The RubyConf Taiwan 2023 Edition)

New features

  • #272: Add new Minitest/RedundantMessageArgument cop. (@​koic)
  • #279: Add new Minitest/NonExecutableTestMethod cop. (@​koic)

Bug fixes

  • #275: Make Minitest/AssertMatch aware of assert_operator when running with Ruby 2.7. (@​koic)
  • #271: Fix a false positive for Minitest/EmptyLineBeforeAssertionMethods and assert_raises. (@​fatkodima)

Changes

Changelog

Sourced from rubocop-minitest's changelog.

0.34.1 (2023-12-16)

Bug fixes

  • #281: Fix an error when assigning a value to an object attribute. ([@​koic][])

0.34.0 (2023-12-16)

New features

  • #272: Add new Minitest/RedundantMessageArgument cop. ([@​koic][])
  • #279: Add new Minitest/NonExecutableTestMethod cop. ([@​koic][])

Bug fixes

  • #275: Make Minitest/AssertMatch aware of assert_operator when running with Ruby 2.7. ([@​koic][])
  • #271: Fix a false positive for Minitest/EmptyLineBeforeAssertionMethods and assert_raises. ([@​fatkodima][])

Changes

Commits
  • 56f2263 Cut 0.34.1
  • 3e109b8 Update Changelog
  • 5ba16c7 Merge pull request #282 from koic/fix_an_error_when_using_assigning_a_value_t...
  • b7587e5 [Fix #281] Fix an error when assigning a value to an object attribute
  • 8f8f0e4 Add a missing changelog entry
  • be9d54a Switch back docs version to master
  • 33e2db5 Cut 0.34.0
  • 0b2911f Update Changelog
  • a31118d Merge pull request #280 from koic/add_new_minitest_non_executable_test_method...
  • 6306fd5 [Fix #279] Add new Minitest/NonExecutableTestMethod cop
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from murny as a code owner December 18, 2023 17:48
@dependabot dependabot bot added the ruby Pull requests that update Ruby code label Dec 18, 2023
@dependabot dependabot bot requested a review from pgwillia as a code owner December 18, 2023 17:48
@dependabot dependabot bot force-pushed the dependabot/bundler/master/rubocop-minitest-0.34.1 branch from 629b565 to 01ac01b Compare December 18, 2023 23:08
@murny
Copy link
Collaborator

murny commented Dec 18, 2023

Think there is a bug with this release. Crashing on "Minitest/MultipleAssertions cop":

An error occurred while Minitest/MultipleAssertions cop was inspecting /Users/murny/Code/Misc/jupiter/test/system/deposit_thesis_test.rb:3:0.
undefined method `assignment?' for nil:NilClass

    return assertion_method?(node.expression) if node.assignment? && node.respond_to?(:expression)
                                                     ^^^^^^^^^^^^

/Users/murny/.asdf/installs/ruby/3.1.4/lib/ruby/gems/3.1.0/gems/rubocop-minitest-0.34.1/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb:104:in `assertion_method?'

This issue might be related:
rubocop/rubocop-minitest#283

EDIT: This is now fixed in v0.34.2

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 25, 2023

A newer version of rubocop-minitest exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot bot and others added 2 commits December 27, 2023 16:47
Bumps [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) from 0.33.0 to 0.34.1.
- [Release notes](https://github.com/rubocop/rubocop-minitest/releases)
- [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-minitest@v0.33.0...v0.34.1)

---
updated-dependencies:
- dependency-name: rubocop-minitest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@murny murny force-pushed the dependabot/bundler/master/rubocop-minitest-0.34.1 branch from 44ab2bc to a8a4b53 Compare December 27, 2023 23:47
@murny murny changed the title Bump rubocop-minitest from 0.33.0 to 0.34.1 Bump rubocop-minitest from 0.33.0 to 0.34.2 Dec 27, 2023
@murny murny enabled auto-merge December 27, 2023 23:55
@murny murny merged commit c1e747a into master Dec 27, 2023
3 checks passed
@murny murny deleted the dependabot/bundler/master/rubocop-minitest-0.34.1 branch December 27, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant