Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter to getPeopleWithMultivaluedAttributes caching #2850

Conversation

Naenyn
Copy link
Contributor

@Naenyn Naenyn commented Sep 16, 2024

Checklist
Description of change

PR 2280 introduced a bug related to attempted caching of the IPersonAttributeDao.getPeopleWithMultivaluedAttributes method. This PR fixes that bug by adding the newly introduced filter to PersonDirectoryCacheKeyGenerator.CachableMethod enum and reference.

Sorry, something went wrong.

@Naenyn Naenyn requested a review from bjagg September 16, 2024 19:22
Copy link
Member

@bjagg bjagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Naenyn Naenyn merged commit be09282 into uPortal-Project:master Sep 16, 2024
8 checks passed
@Naenyn Naenyn deleted the bugfix/pr_2280-person_directory_cache_fix branch September 16, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants