Update to AnalyticsPortalEvents for new requirements #2594
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @Override | ||
| public List<AnalyticsPortalEvent> getAnalytics( | ||
| DateTime startDate, DateTime endDate, String eventType, String broncoId) { | ||
| final List<AnalyticsPortalEvent> portalEvents = new LinkedList<AnalyticsPortalEvent>(); |
There was a problem hiding this comment.
JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.
| final List<AnalyticsPortalEvent> portalEvents = new LinkedList<AnalyticsPortalEvent>(); | |
| final List<AnalyticsPortalEvent> portalEvents = new ArrayList<AnalyticsPortalEvent>(); |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| String broncoId, | ||
| FunctionWithoutResult<AnalyticsPortalEvent> handler) { | ||
| final TypedQuery<PersistentPortalEvent> query = | ||
| this.getEntityManager().createQuery(this.selectQuery, PersistentPortalEvent.class); |
There was a problem hiding this comment.
SQL_INJECTION_JPA: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;Ljava/lang/Class;)Ljavax/persistence/TypedQuery; can be vulnerable to SQL/JPQL injection (with JPA)
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @Override | ||
| public List<PortalEvent> getAnalytics( | ||
| DateTime startDate, DateTime endDate, String eventType, String broncoId) { | ||
| final List<PortalEvent> portalEvents = new LinkedList<PortalEvent>(); |
There was a problem hiding this comment.
JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.
| final List<PortalEvent> portalEvents = new LinkedList<PortalEvent>(); | |
| final List<PortalEvent> portalEvents = new ArrayList<PortalEvent>(); |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Checklist
Description of change
Update AnalyticsPortalEvent to include ipAddress in event; add REST endpoint to query events