-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): include alpha pre-releases in parser peer dependency #9099
Conversation
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Thanks for the PR, @bachmacintosh! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
PR Checklist
Overview
A fix for #9087 was pushed in #9089 to bump the eslint-plugin's peerDependencdy on the parser to
^8.0.0
, but due to how NPM handles SemVer, it does not include pre-releases such as8.0.0-alpha.11
, causing a "version not found" error if someone tried to install the pre-release plugin (eg on tagrc-v8
). This PR adds another SemVer constraint to the@typescript-eslint/parser
peerDependency to include alpha pre-releases as suggested in #9089 (comment)