Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): include alpha pre-releases in parser peer dependency #9099

Merged
merged 2 commits into from
May 15, 2024

Conversation

bachmacintosh
Copy link

PR Checklist

Overview

A fix for #9087 was pushed in #9089 to bump the eslint-plugin's peerDependencdy on the parser to ^8.0.0, but due to how NPM handles SemVer, it does not include pre-releases such as 8.0.0-alpha.11, causing a "version not found" error if someone tried to install the pre-release plugin (eg on tag rc-v8). This PR adds another SemVer constraint to the @typescript-eslint/parser peerDependency to include alpha pre-releases as suggested in #9089 (comment)

Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bachmacintosh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8cde603
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66440dfdae045a000727da2a
😎 Deploy Preview https://deploy-preview-9099--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bachmacintosh bachmacintosh changed the title fix(eslint-plugin): Include Alpha Pre-Releases in Parser peerDependency fix(eslint-plugin): include alpha pre-releases in parser peer dependency May 15, 2024
Copy link

nx-cloud bot commented May 15, 2024

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@bradzacher bradzacher merged commit 5753fe5 into typescript-eslint:v8 May 15, 2024
60 of 61 checks passed
@bachmacintosh bachmacintosh deleted the v8-parser-dep branch May 15, 2024 05:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants