chore: add breaking change pr check ci

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Repo: Add a CI check that 'breaking change' PR descriptions start with the right title text #9027, fixes Repo: Add a CI check that 'breaking change' PR descriptions start with the right body text #5884
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Add CI that checks breaking change pr title and body.

• Disallows the use of exclamation mark(!) in PR title.
• Enforces to write “BREAKING CHANGE:” at the beginning of the PR body if the pr has breaking change label.

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	cde7ec4
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/663f5339678e1e0008618922
😎 Deploy Preview	https://deploy-preview-9050--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cde7ec4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test scope-manager --coverage=false
• nx test typescript-eslint --coverage=false
• nx test utils --coverage=false
• nx run types:build
• nx test typescript-estree --coverage=false
• nx test type-utils --coverage=false
• nx run repo-tools:postinstall-script
• nx test visitor-keys --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test repo-tools --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx test eslint-plugin --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test ast-spec --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test ast-spec
• nx test eslint-plugin-internal
• nx test type-utils
• nx test visitor-keys
• nx test eslint-plugin
• nx test scope-manager
• nx test rule-schema-to-typescript-types
• nx test utils
• nx test typescript-estree
• nx test parser
• nx test typescript-eslint
• nx test repo-tools
• nx run-many --target=typecheck --parallel
• nx run repo-tools:generate-configs
• nx run integration-tests:test

---

Sent with 💌 from NxCloud.

[auvred]

Hmmm, isn't this too restrictive? I can imagine the several cases when ! might be used not in the "breaking changes" position (before the semicolon)

Here are several real world PRs that have an exclamation mark in their titles:

• feat(eslint-plugin): [prefer-optional-chain] support suggesting !foo || !foo.bar as a valid match for the rule #5594
• docs: add missing ! (...) around comparison cases in no-unnecessary-boolean-literal-compare fixer #6968
• feat(eslint-plugin): [no-extra-non-null-assertion] flag optional chain after a non-null assertion #1460

I guess we should restrict only the use of feat(...)!: ... and feat!: .... What do you think?

[auvred]

One small note on PR title RegExp, otherwise LGTM!

[auvred]

Suggested change

	if (/^[a-z]+(\([a-z]+\))?!: /.test(title)) {
	if (/^[a-z]+(\([a-z-]+\))?!: /.test(title)) {

Without the dash, this regexp won't catch feat(eslint-plugin)!: ...

[yeonjuan]

Thanks! I fixed it cde7ec4

[auvred]