fix(eslint-plugin): [no-floating-promises] check top-level type assertions (and more)

[kirkwaiblinger]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-floating-promises] support TsAsExpression #8692
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Changes implementation from an unhandled promise syntax allowlist to a syntax denylist.

[typescript-eslint]

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	79fa0f6
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66357e7fd617d9000852fd15
😎 Deploy Preview	https://deploy-preview-9043--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[kirkwaiblinger]

These changes are just because declare is not syntactically allowed in that position (it's required to be at top level). Just some hygiene, not relevant to the changes.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 79fa0f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test typescript-eslint --coverage=false
• nx run types:build
• nx run repo-tools:postinstall-script
• nx test rule-schema-to-typescript-types --coverage=false
• nx test typescript-estree --coverage=false
• nx test scope-manager --coverage=false
• nx test visitor-keys --coverage=false
• nx test utils --coverage=false
• nx test type-utils --coverage=false
• nx test repo-tools --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test parser --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test ast-spec --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test type-utils
• nx test parser
• nx test eslint-plugin-internal
• nx test typescript-estree
• nx test repo-tools
• nx test utils
• nx test visitor-keys
• nx test typescript-eslint
• nx test rule-schema-to-typescript-types
• nx test scope-manager
• nx run-many --target=typecheck --parallel
• nx run repo-tools:generate-configs
• nx test ast-spec
• nx run integration-tests:test

---

Sent with 💌 from NxCloud.

[kirkwaiblinger]

surprisingly, assignments without a declaration were not tested for