Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): reduce Contributor_Tiers page's table vertical Padding #9041

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

by replace br to new line, vertical padding is reduced

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 26b969c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665c500948718700084696c0
😎 Deploy Preview https://deploy-preview-9041--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! 💪

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most of the way there, but there's still some padding below the paragraphs that's a little awkward:

Screenshot of the updated table with some padding below each multiline paragraph still

I think you'll have to change some CSS around to get rid of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fix margin like below
스크린샷 2024-06-02 오후 7 58 49

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label May 26, 2024
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Issues waiting for a reply from the OP or another party documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Unusually large padding after table cell lines in Contributor_Tiers.mdx
3 participants