Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule-tester): check for missing placeholder data in the message #9039

Merged

Conversation

Vinccool96
Copy link
Contributor

@Vinccool96 Vinccool96 commented May 2, 2024

PR Checklist

Overview

Brings in changes from eslint/eslint#18073. This is pretty much a copy & paste.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit daaf6a8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6633aaf6be8f790008d73822
😎 Deploy Preview https://deploy-preview-9039--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vinccool96 Vinccool96 changed the title Enhancement(rule-tester): check for missing placeholder data in the message feat(rule-tester): check for missing placeholder data in the message May 2, 2024
@Vinccool96
Copy link
Contributor Author

Vinccool96 commented May 7, 2024

@JoshuaKGoldberg Anything I should modify in my PR? Should it go in main or in v8?

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! 💯

The only blocker was one of us having time to review it... 😄

@JoshuaKGoldberg
Copy link
Member

main is the right one - we're treating these as non-breaking. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5110248 into typescript-eslint:main May 9, 2024
62 of 63 checks passed
@Vinccool96 Vinccool96 deleted the missing-placeholder-data branch May 10, 2024 14:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement(rule-tester): check for missing placeholder data in the message
2 participants