Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-type-assertion] allow non-null assertion for void type #8912

Merged
merged 2 commits into from Apr 22, 2024

Conversation

yeonjuan
Copy link
Contributor

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 198ce1a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6626997eb2c20f00080f1603
😎 Deploy Preview https://deploy-preview-8912--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

auvred
auvred previously approved these changes Apr 19, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🔥

@auvred auvred added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Apr 19, 2024
@@ -189,14 +189,13 @@ export default createRule<Options, MessageIds>({

const type = getConstrainedTypeAtLocation(services, node.expression);

if (!isNullableType(type)) {
if (!isNullableType(type) && !isTypeFlagSet(type, ts.TypeFlags.Void)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question - should void just be part of isNullableType?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirkwaiblinger A quick check shows that modifying isNullableType seems to work fine. However, if we do modify this function, it would be nice to add some tests to other rules that use it. What do you think about creating a separate issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from auvred and themself via 198ce1a April 22, 2024 17:08
@JoshuaKGoldberg JoshuaKGoldberg merged commit b2552ca into typescript-eslint:main Apr 22, 2024
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready
Projects
None yet
4 participants