Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-for-in-array] refine report location #8874

Merged

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

just reduces the amount of squigglies

// before
for (const i in array) { console.log(array[i]); }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// after
for (const i in array) { console.log(array[i]); }
^^^^^^^^^^^^^^^^^^^^^^

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4de9b2a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66157b7494d6aa0008845afa
😎 Deploy Preview https://deploy-preview-8874--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review April 7, 2024 16:40
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a tricky set of changes 😄 nice!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Apr 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit fdeba42 into typescript-eslint:main Apr 22, 2024
57 checks passed
@kirkwaiblinger kirkwaiblinger deleted the for-in-array-report-loc branch April 22, 2024 17:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants