Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name field to shared configs and flat config types #8863

Merged
merged 2 commits into from Apr 6, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Apr 6, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d117464
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6610f96e7725510008561525
😎 Deploy Preview https://deploy-preview-8863--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Should go a long way in helping with debugability

@@ -215,6 +215,7 @@ async function main(): Promise<void> {
];
const flatExtends: string[] = [];
const flatConfig: FlatConfig.Config = {
name: `typescript-eslint/${name}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of me thinks we should do this as @ but given they're from the non-namespaced package it's probably better to be consistent and name it without the @.

@bradzacher bradzacher merged commit 679ed8e into typescript-eslint:main Apr 6, 2024
57 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: support name field in flat config types
2 participants