Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unsafe-assignment] handle shorthand property assignment #8800

Merged
merged 5 commits into from Apr 19, 2024

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 38bb437
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66228c12f8dfee00087a6194
😎 Deploy Preview https://deploy-preview-8800--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@yeonjuan yeonjuan marked this pull request as ready for review March 29, 2024 15:38
@bradzacher bradzacher added the bug Something isn't working label Apr 4, 2024
@yeonjuan
Copy link
Contributor Author

yeonjuan commented Apr 10, 2024

The coverage check fails because there is no test for getContextualType. Do we need to add a test for it? If so, I'd file a new issue for it.

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commented Apr 19, 2024

The coverage check fails because there is no test for getContextualType.

This is a great example of #8358 😆

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squeaky clean! Thanks!
nice!

@kirkwaiblinger kirkwaiblinger added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Apr 19, 2024
@kirkwaiblinger kirkwaiblinger merged commit d07eb9e into typescript-eslint:main Apr 19, 2024
58 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unsafe-assignment] any => unknown assignment triggers error for object shorthand notation
3 participants