fix(eslint-plugin): [no-floating-promises] handle TaggedTemplateExpression

[naruaway]

PR Checklist

• Addresses an existing open issue: fixes #000
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This PR makes "no-floating-promises" rule to raise error when floating promise is created from a tagged templates, which is essentially a function call in this context.
The motivating example is with dax, which is a popular library to write shell script in TypeScript.
Its $ API is a tagged template and it returns a Promise (with other methods on it) and we need to await on that.
If we forget to await, execution orders will be messed up and the main script might exit too early.

After this PR, "no-floating-promises" will be able to capture the mistake in the following snippet:

import $ from 'dax-sh'

// Here we are forgetting `await` and , "no-floating-promises" cannot detect it without the PR
$`echo hello`
$`echo world`

I added the corresponding test cases in the PR and confirmed that the test fails before the implementation change in this PR.

[typescript-eslint]

Thanks for the PR, @naruaway!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	7c8c9dd
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6601b29c28655f00086b2149
😎 Deploy Preview	https://deploy-preview-8758--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7c8c9dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx run types:build
• nx run repo-tools:postinstall-script
• nx test rule-schema-to-typescript-types
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test typescript-eslint --coverage=false
• nx test parser --coverage=false
• nx test utils
• nx test parser
• nx test ast-spec
• nx test typescript-estree --coverage=false
• nx test type-utils
• nx test typescript-estree
• nx test eslint-plugin
• nx test scope-manager
• nx test eslint-plugin --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test eslint-plugin-internal
• nx test visitor-keys
• nx test typescript-eslint
• nx test repo-tools
• nx run-many --target=typecheck --parallel
• nx test type-utils --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test scope-manager --coverage=false
• nx test ast-spec --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test repo-tools --coverage=false
• nx test utils --coverage=false
• nx test visitor-keys --coverage=false
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (e408b93) to head (7c8c9dd).
Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8758      +/-   ##
==========================================
- Coverage   87.98%   87.36%   -0.63%     
==========================================
  Files         404      255     -149     
  Lines       14045    12498    -1547     
  Branches     4110     3923     -187     
==========================================
- Hits        12358    10919    -1439     
+ Misses       1382     1304      -78     
+ Partials      305      275      -30     

Flag	Coverage Δ
unittest	87.36% <100.00%> (-0.63%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts	100.00% <100.00%> (ø)

... and 156 files with indirect coverage changes

[Josh-Cena]

I don't know if they work differently but could you add tests for tag`aaa`.then, tag`aaa`.catch, and tag`aaa`.finally?

[naruaway]

@Josh-Cena thanks for the review, I just added test cases for then/catch/finally for sure. I think adding these makes sense to make sure the logic is the same as the function call

[JoshuaKGoldberg]

We normally ask that PRs (other than small docs fixes) have a backing issue for discussion. But this one is pretty small and straightforward. Just requesting changes on tests. Thanks! 🏷️

[JoshuaKGoldberg]