Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): make 404 page good again #8750

Merged
merged 3 commits into from Mar 23, 2024

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Mar 22, 2024

PR Checklist

Overview

NotFound => NotFoundContent, and PageMetadata and Layout are also not needed anymore 👍🏻

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9e6d4b2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65fee86f12df2900083f5157
😎 Deploy Preview https://deploy-preview-8750--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@abrahamguo abrahamguo changed the title move inside content fix(website): Make 404 page good again Mar 22, 2024
@abrahamguo abrahamguo changed the title fix(website): Make 404 page good again fix(website): make 404 page good again Mar 22, 2024
Josh-Cena
Josh-Cena previously approved these changes Mar 22, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 thanks!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..oh, except for the lint issues:


/home/runner/work/typescript-eslint/typescript-eslint/packages/website/src/theme/NotFound/Content/index.tsx
  2:10  error  'PageMetadata' is defined but never used. Allowed unused vars must match /^_/u  @typescript-eslint/no-unused-vars
  3:8   error  'Layout' is defined but never used. Allowed unused vars must match /^_/u        @typescript-eslint/no-unused-vars

Got a moment to fix for them?

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 22, 2024
@armano2
Copy link
Member

armano2 commented Mar 23, 2024

there seem to br also small issue on firefox, this underline image seem to be missaligned
screenshot

Copy link

Uh oh! @armano2, the image you shared is missing helpful alt text. Check #8750 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4132374 into typescript-eslint:main Mar 23, 2024
59 checks passed
peanutenthusiast pushed a commit to peanutenthusiast/typescript-eslint that referenced this pull request Mar 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: 404 page is boring again
4 participants