fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside

[marcalexiei]

PR Checklist

• Addresses an existing open issue: fixes [@typescript-eslint/no-unnecessary-type-assertion] False positives for "as const" assertions with template literals #8737
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

no-unnecessary-type-assertion now avoids to remove const casting from template literals when they are containing expressions.

This scenario is handled inside isConstVariableDeclaration which has been renamed to isLiteralVariableDeclarationChangingTypeWithConst to better reflect its purpose.

Edit: missed appreciation note... sorry
😅

[typescript-eslint]

Thanks for the PR, @marcalexiei!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	e29f5cf
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65fc8754f1e11200085205ea
😎 Deploy Preview	https://deploy-preview-8740--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e29f5cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test visitor-keys
• nx run types:build
• nx test type-utils
• nx test utils
• nx run repo-tools:postinstall-script
• nx test typescript-eslint
• nx test typescript-estree
• nx test rule-schema-to-typescript-types
• nx test scope-manager
• nx test repo-tools
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test parser
• nx test ast-spec
• nx test eslint-plugin-internal
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx run-many --target=typecheck --parallel
• nx test typescript-eslint --coverage=false
• nx test parser --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test ast-spec --coverage=false
• nx test visitor-keys --coverage=false
• nx test typescript-estree --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test scope-manager --coverage=false
• nx test utils --coverage=false
• nx test type-utils --coverage=false
• nx run repo-tools:generate-configs
• nx test repo-tools --coverage=false
• nx run integration-tests:test

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (59bbf41) to head (e29f5cf).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8740   +/-   ##
=======================================
  Coverage   87.38%   87.39%           
=======================================
  Files         254      254           
  Lines       12489    12492    +3     
  Branches     3919     3920    +1     
=======================================
+ Hits        10914    10917    +3     
  Misses       1304     1304           
  Partials      271      271           

Flag	Coverage Δ
unittest	87.39% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts	97.10% <100.00%> (+0.13%)	⬆️

[JoshuaKGoldberg]

Ha, tricky stuff - thanks!

And appreciated on the appreciation note. 😁