Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restrict-template-expressions - remove mention of numbers being allowed #8734

Merged

Conversation

llllvvuu
Copy link
Contributor

In the recommended config, numbers are allowed, but so are several other types. In the strict config, numbers are not allowed (#8364). Either way, "string and number" might not be the right documentation for what's allowed.

PR Checklist

N/A - small docs edit

Overview

small docs edit

…allowed

In the `recommended` config, numbers are allowed, but so are several
other types. In the `strict` config, numbers are not allowed. Either
way, "string and number" might not be the right documentation for what's
allowed.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @llllvvuu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 56de4c4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65fa1f53f3d762000813c51f
😎 Deploy Preview https://deploy-preview-8734--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@llllvvuu llllvvuu changed the title docs(restrict-template-expressions): remove mention of numbers being allowed docs: restrict-template-expressions - remove mention of numbers being allowed Mar 20, 2024
@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Mar 21, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit c787fe4 into typescript-eslint:main Mar 24, 2024
61 of 62 checks passed
peanutenthusiast pushed a commit to peanutenthusiast/typescript-eslint that referenced this pull request Mar 27, 2024
… allowed (typescript-eslint#8734)

docs(restrict-template-expressions): remove mention of numbers being allowed

In the `recommended` config, numbers are allowed, but so are several
other types. In the `strict` config, numbers are not allowed. Either
way, "string and number" might not be the right documentation for what's
allowed.
yeonjuan pushed a commit to yeonjuan/typescript-eslint that referenced this pull request Mar 31, 2024
… allowed (typescript-eslint#8734)

docs(restrict-template-expressions): remove mention of numbers being allowed

In the `recommended` config, numbers are allowed, but so are several
other types. In the `strict` config, numbers are not allowed. Either
way, "string and number" might not be the right documentation for what's
allowed.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants