Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-floating-promises] revert disable of ignoreVoid in strict config #8718

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Reverts specifically the part of #8364 that had no-floating-promises disable allowing void in the strict-type-checked config.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d0eada0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f8c3421e18e000083d1fae
😎 Deploy Preview https://deploy-preview-8718--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

bradzacher
bradzacher previously approved these changes Mar 18, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit d78d98b into typescript-eslint:main Mar 18, 2024
55 of 57 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: differences between recommended and strict configs not mentioned on the website
2 participants