Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): visual Editor is not scrolled #8709

Merged

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

It seems like a simple task, but if there are any side effects that you might not know about, please let me know!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1e6a5bd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f8463600c97e0008c14595
😎 Deploy Preview https://deploy-preview-8709--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (01cbca5) to head (1e6a5bd).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8709      +/-   ##
==========================================
+ Coverage   87.21%   87.38%   +0.17%     
==========================================
  Files         251      254       +3     
  Lines       12305    12489     +184     
  Branches     3880     3919      +39     
==========================================
+ Hits        10732    10914     +182     
- Misses       1303     1304       +1     
- Partials      270      271       +1     
Flag Coverage Δ
unittest 87.38% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit 775497c into typescript-eslint:main Mar 19, 2024
57 of 60 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: visual editor in playground should be scrollable
3 participants