Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-unnecessary-type-arguments] handle tagged templates #8708

Merged
merged 1 commit into from Mar 25, 2024

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7481a9b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65fc5bfc19580f0008433e1d
😎 Deploy Preview https://deploy-preview-8708--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (59bbf41) to head (7481a9b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8708   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files         254      254           
  Lines       12489    12490    +1     
  Branches     3919     3920    +1     
=======================================
+ Hits        10914    10915    +1     
  Misses       1304     1304           
  Partials      271      271           
Flag Coverage Δ
unittest 87.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-arguments.ts 96.29% <100.00%> (+0.06%) ⬆️

@yeonjuan yeonjuan marked this pull request as ready for review March 18, 2024 15:46
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyonce in black-and-white looking up and saying 'flawless'

@JoshuaKGoldberg JoshuaKGoldberg merged commit a08554a into typescript-eslint:main Mar 25, 2024
59 checks passed
peanutenthusiast pushed a commit to peanutenthusiast/typescript-eslint that referenced this pull request Mar 27, 2024
yeonjuan added a commit to yeonjuan/typescript-eslint that referenced this pull request Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-unnecessary-type-arguments] Check unnecessary type arguments in Tagged templates
2 participants