New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): fix the issue of single run inferring in the pnpm repo (#3811) #8702
fix(typescript-estree): fix the issue of single run inferring in the pnpm repo (#3811) #8702
Conversation
Thanks for the PR, @xqxian! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dcc6a52
to
0aa1098
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8702 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 402 402
Lines 14029 14031 +2
Branches 4117 4117
=======================================
+ Hits 12360 12362 +2
Misses 1370 1370
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a pnpm user, I'm very excited to see this come in. Also glad it was only a few lines of code. Thanks! 🔥
Normally I'd ask for unit tests, but given that inferSingleRun
doesn't have any yet, I'll just file a followup issue.
63b760a
into
typescript-eslint:main
PR Checklist
Overview
Add a check for the eslint bin path in the
inferSingleRun
method within the pnpm repository.