Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix the issue of single run inferring in the pnpm repo (#3811) #8702

Conversation

xqxian
Copy link
Contributor

@xqxian xqxian commented Mar 17, 2024

PR Checklist

Overview

Add a check for the eslint bin path in the inferSingleRun method within the pnpm repository.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @xqxian!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0aa1098
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f74095c6767b0008385d92
😎 Deploy Preview https://deploy-preview-8702--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@xqxian xqxian force-pushed the fix/single-run-inferring-in-pnpm-repo branch from dcc6a52 to 0aa1098 Compare March 17, 2024 19:12
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (3856c67) to head (0aa1098).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8702   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files         402      402           
  Lines       14029    14031    +2     
  Branches     4117     4117           
=======================================
+ Hits        12360    12362    +2     
  Misses       1370     1370           
  Partials      299      299           
Flag Coverage Δ
unittest 88.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...escript-estree/src/parseSettings/inferSingleRun.ts 93.75% <100.00%> (+0.89%) ⬆️

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a pnpm user, I'm very excited to see this come in. Also glad it was only a few lines of code. Thanks! 🔥

Normally I'd ask for unit tests, but given that inferSingleRun doesn't have any yet, I'll just file a followup issue.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 63b760a into typescript-eslint:main Mar 18, 2024
57 of 59 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pnpm for single run detection
2 participants