Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): deprecate no-throw-literal and add a renamed only-throw-error #8701

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Effectively renames no-throw-literal to only-throw-error. This avoids being a breaking change per #6109's suggestion by keeping the rule under the old name as well.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a4c19ef
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6601ade8b9b0a3000847b701
😎 Deploy Preview https://deploy-preview-8701--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👍

Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! But there is small docs issue

packages/eslint-plugin/docs/rules/no-throw-literal.mdx Outdated Show resolved Hide resolved
@auvred auvred added the awaiting response Issues waiting for a reply from the OP or another party label Mar 25, 2024
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
@JoshuaKGoldberg JoshuaKGoldberg merged commit 029fc0b into typescript-eslint:main Mar 25, 2024
54 of 55 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the rename-no-throw-literal-to-only-throw-error branch March 25, 2024 17:10
peanutenthusiast pushed a commit to peanutenthusiast/typescript-eslint that referenced this pull request Mar 27, 2024
…y-throw-error (typescript-eslint#8701)

* feat(eslint-plugin): deprecate no-throw-literal and add a renamed only-throw-error

* Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx

Co-authored-by: YeonJuan <yeonjuan93@naver.com>

* Updated options snapshot

* Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

---------

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
yeonjuan added a commit to yeonjuan/typescript-eslint that referenced this pull request Mar 31, 2024
…y-throw-error (typescript-eslint#8701)

* feat(eslint-plugin): deprecate no-throw-literal and add a renamed only-throw-error

* Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx

Co-authored-by: YeonJuan <yeonjuan93@naver.com>

* Updated options snapshot

* Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

---------

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-throw-literal] Rename to only-throw-error
3 participants