Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-unused-expressions] false negatives when using assertions #8668

Merged
merged 7 commits into from
Mar 17, 2024
Merged

fix(eslint-plugin): [no-unused-expressions] false negatives when using assertions #8668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e65bb6f
fix [no-unused-expressions] false negatives when using assertions
up201304504 Mar 13, 2024
9f96e92
fix [no-unused-expressions] false negatives when using assertions
up201304504 Mar 13, 2024
2dab6ca
Updating tests
jsfm01 Mar 13, 2024
f50d624
Merge branch 'main' into fix/8654-no-unused-expressions
up201304504 Mar 13, 2024
0110f89
fix [no-unused-expressions] false negatives when using assertions
up201304504 Mar 14, 2024
d60c925
Fixing linting issue on test
jsfm01 Mar 15, 2024
dc3a949
Merge branch 'main' into fix/8654-no-unused-expressions
up201304504 Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/eslint-plugin/src/rules/no-unused-expressions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,14 @@ export default createRule<Options, MessageIds>({
return;
}

const expressionType = node.expression.type;

if (
node.expression.type ===
TSESTree.AST_NODE_TYPES.TSInstantiationExpression
expressionType ===
TSESTree.AST_NODE_TYPES.TSInstantiationExpression ||
expressionType === TSESTree.AST_NODE_TYPES.TSAsExpression ||
expressionType === TSESTree.AST_NODE_TYPES.TSNonNullExpression ||
expressionType === TSESTree.AST_NODE_TYPES.TSTypeAssertion
) {
rules.ExpressionStatement({
...node,
Expand Down
56 changes: 56 additions & 0 deletions packages/eslint-plugin/tests/rules/no-unused-expressions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,5 +325,61 @@ Foo<string>;
},
]),
},
{
code: `
declare const foo: number | undefined;
foo;
`,
errors: error([
{
line: 3,
endLine: 3,
column: 1,
endColumn: 5,
},
]),
},
{
code: `
declare const foo: number | undefined;
foo as any;
`,
errors: error([
{
line: 3,
endLine: 3,
column: 1,
endColumn: 12,
},
]),
},
{
code: `
declare const foo: number | undefined;
<any>foo;
`,
errors: error([
{
line: 3,
endLine: 3,
column: 1,
endColumn: 10,
},
]),
},
{
code: `
declare const foo: number | undefined;
foo!;
`,
errors: error([
{
line: 3,
endLine: 3,
column: 1,
endColumn: 6,
},
]),
},
],
});