fix(eslint-plugin): [unbound-method] check method definition in object literal using longhand form

[kirkwaiblinger]

PR Checklist

• Addresses an existing open issue: fixes Bug: [unbound-method] should flag on method in object literal defined using longhand form #8636
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Just added the same validation to the long form method syntax as already exists for the short form, i.e.

{
   // this
   f: function() {},
   // is now scrutinized the same as 
   g() {}
}

[typescript-eslint]

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	2d2bdfc
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65ed2810840e3700070f5558
😎 Deploy Preview	https://deploy-preview-8637--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2d2bdfc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test visitor-keys
• nx test eslint-plugin --coverage=false
• nx run types:build
• nx run repo-tools:postinstall-script
• nx test typescript-estree
• nx test scope-manager
• nx test typescript-eslint
• nx test type-utils
• nx test utils
• nx test repo-tools
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test rule-schema-to-typescript-types
• nx test parser
• nx test ast-spec
• nx test eslint-plugin-internal
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test visitor-keys --coverage=false
• nx run-many --target=typecheck --parallel
• nx test eslint-plugin-internal --coverage=false
• nx test ast-spec --coverage=false
• nx test typescript-eslint --coverage=false
• nx test typescript-estree --coverage=false
• nx test utils --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run integration-tests:test
• nx test parser --coverage=false
• nx test type-utils --coverage=false
• nx test scope-manager --coverage=false
• nx test repo-tools --coverage=false
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.23%. Comparing base (858c9a6) to head (2d2bdfc).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8637      +/-   ##
==========================================
+ Coverage   87.21%   87.23%   +0.02%     
==========================================
  Files         251      251              
  Lines       12305    12309       +4     
  Branches     3880     3881       +1     
==========================================
+ Hits        10732    10738       +6     
+ Misses       1303     1301       -2     
  Partials      270      270              

Flag	Coverage Δ
unittest	87.23% <92.85%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts	95.29% <92.85%> (+2.70%)	⬆️

[kirkwaiblinger]

the window tests are not related to the bug, just things i came up with while trying to figure out how to satisfy codecov.

[kirkwaiblinger]

this is the only logic change

[auvred]

LGTM! 🔥