New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support TS 5.4 #8630
feat: support TS 5.4 #8630
Conversation
Thanks for the PR, @strmer15! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8630 +/- ##
==========================================
+ Coverage 87.21% 87.98% +0.77%
==========================================
Files 251 401 +150
Lines 12305 13905 +1600
Branches 3880 4086 +206
==========================================
+ Hits 10732 12235 +1503
- Misses 1303 1370 +67
- Partials 270 300 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the issue #8314 - we will need to regenerate the lib.d.ts types.
There is also more to do than just those numbers.
Feel free to action it - here is the guide:
https://typescript-eslint.io/maintenance/pull-requests/dependency-version-upgrades#adding-support-for-a-new-typescript-version
Start at step 4
Thanks @bradzacher ! I looked at step 4, but it's only about updating an RC version of Typescript, which isn't the case here - this is the GA version, so I skipped to step 6. I updated the types and then updated the doc as well, it was asking to change Let me know if there's anything else to do to get TS 5.4 supported, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for doing this!
PR Checklist
Overview
This adds support for Typescript 5.4, which was recently released as generally available - https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/
The only changes I made were to the version used by the root
package.json
and the supported TS versions intypescript-estree
.