Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TS 5.4 #8630

Merged
merged 5 commits into from Mar 11, 2024
Merged

Conversation

strmer15
Copy link
Contributor

@strmer15 strmer15 commented Mar 8, 2024

PR Checklist

Overview

This adds support for Typescript 5.4, which was recently released as generally available - https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/

The only changes I made were to the version used by the root package.json and the supported TS versions in typescript-estree.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @strmer15!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ac13f8a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65eb7e4b2f329800086fb0ed
😎 Deploy Preview https://deploy-preview-8630--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (9f6f391) to head (ac13f8a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8630      +/-   ##
==========================================
+ Coverage   87.21%   87.98%   +0.77%     
==========================================
  Files         251      401     +150     
  Lines       12305    13905    +1600     
  Branches     3880     4086     +206     
==========================================
+ Hits        10732    12235    +1503     
- Misses       1303     1370      +67     
- Partials      270      300      +30     
Flag Coverage Δ
unittest 87.98% <100.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/scope-manager/src/lib/dom.asynciterable.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/dom.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2016.intl.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2016.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2018.full.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2019.full.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2020.full.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2021.full.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2022.full.ts 100.00% <100.00%> (ø)
... and 12 more

... and 130 files with indirect coverage changes

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the issue #8314 - we will need to regenerate the lib.d.ts types.

There is also more to do than just those numbers.
Feel free to action it - here is the guide:
https://typescript-eslint.io/maintenance/pull-requests/dependency-version-upgrades#adding-support-for-a-new-typescript-version

Start at step 4

@strmer15
Copy link
Contributor Author

strmer15 commented Mar 8, 2024

As per the issue #8314 - we will need to regenerate the lib.d.ts types.

There is also more to do than just those numbers. Feel free to action it - here is the guide: https://typescript-eslint.io/maintenance/pull-requests/dependency-version-upgrades#adding-support-for-a-new-typescript-version

Start at step 4

Thanks @bradzacher !

I looked at step 4, but it's only about updating an RC version of Typescript, which isn't the case here - this is the GA version, so I skipped to step 6.

I updated the types and then updated the doc as well, it was asking to change devDependencies when the typescript version is actually in resolutions now.

Let me know if there's anything else to do to get TS 5.4 supported, thanks!

@trivikr trivikr mentioned this pull request Mar 11, 2024
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this!

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Mar 11, 2024
@bradzacher bradzacher merged commit 3fef9d6 into typescript-eslint:main Mar 11, 2024
59 of 61 checks passed
@strmer15 strmer15 deleted the typescript_5_4 branch March 11, 2024 14:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants