Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-eslint): set sourceType: "module" in base shared config #8622

Merged
merged 1 commit into from Mar 8, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Mar 8, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@auvred auvred changed the title fix(typescript-eslint): set sourceType: module in base shared config fix(typescript-eslint): set sourceType: "module" in base shared config Mar 8, 2024
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit daab216
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65eae808bc877b00089283a3
😎 Deploy Preview https://deploy-preview-8622--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradzacher bradzacher added the bug Something isn't working label Mar 8, 2024
@bradzacher bradzacher merged commit 9176730 into typescript-eslint:main Mar 8, 2024
62 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: flat config incorrectly places sourceType
2 participants