New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): expose *-type-checked-only configs for extension #8600
fix(eslint-plugin): expose *-type-checked-only configs for extension #8600
Conversation
Thanks for the PR, @fpapado! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8600 +/- ##
==========================================
- Coverage 87.90% 87.12% -0.78%
==========================================
Files 397 251 -146
Lines 13844 12268 -1576
Branches 4074 3868 -206
==========================================
- Hits 12170 10689 -1481
+ Misses 1372 1307 -65
+ Partials 302 272 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4c8b06d
into
typescript-eslint:main
PR Checklist
Overview
This PR is a fix for #8599. I noticed that there were tests for asserting the shape of the different configs, so I extended those tests to account for
*-type-checked-only
.I opened this PR because I believe we have some timezone differences, and it seemed nicer than just dropping an issue on your lap. If that is the wrong assumption, I apologise 😌
Please let me know if there is any other information that I can provide!