Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): expose *-type-checked-only configs for extension #8600

Conversation

fpapado
Copy link
Contributor

@fpapado fpapado commented Mar 5, 2024

PR Checklist

Overview

This PR is a fix for #8599. I noticed that there were tests for asserting the shape of the different configs, so I extended those tests to account for *-type-checked-only.

I opened this PR because I believe we have some timezone differences, and it seemed nicer than just dropping an issue on your lap. If that is the wrong assumption, I apologise 😌

Please let me know if there is any other information that I can provide!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fpapado!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e8b1a54
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65e6fa1f53463d0008293363
😎 Deploy Preview https://deploy-preview-8600--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@fpapado fpapado changed the title fix(eslint-plugin): Expose *-type-checked-only configs for extension fix(eslint-plugin): expose *-type-checked-only configs for extension Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (88b7463) to head (e8b1a54).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8600      +/-   ##
==========================================
- Coverage   87.90%   87.12%   -0.78%     
==========================================
  Files         397      251     -146     
  Lines       13844    12268    -1576     
  Branches     4074     3868     -206     
==========================================
- Hits        12170    10689    -1481     
+ Misses       1372     1307      -65     
+ Partials      302      272      -30     
Flag Coverage Δ
unittest 87.12% <ø> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 146 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks, much appreciated!

Animation of a cartoon flower in a hand-held pot. It's opening to reveal the words "thank you".

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4c8b06d into typescript-eslint:main Mar 5, 2024
62 of 63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: *-type-checked-only configs are not exported
2 participants