Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] handle union array and tuple type #8592

Merged
merged 2 commits into from Mar 6, 2024

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Mar 3, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c340d40
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65e85ddafdb5460008bc247f
😎 Deploy Preview https://deploy-preview-8592--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (3ac824b) to head (c340d40).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8592   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         251      251           
  Lines       12272    12274    +2     
  Branches     3871     3871           
=======================================
+ Hits        10694    10696    +2     
  Misses       1306     1306           
  Partials      272      272           
Flag Coverage Δ
unittest 87.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.56% <100.00%> (+0.01%) ⬆️

Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purple-tinted floating dog with sunglasses on a teal background. "NEATO" is animated flashily to enter and exit

@JoshuaKGoldberg JoshuaKGoldberg merged commit 25e6518 into typescript-eslint:main Mar 6, 2024
56 of 59 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-condition] false-positive for array index access optional chaining on array union type
3 participants