fix(eslint-plugin): [no-unnecessary-qualifier] handle merge namespace with enum

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-unnecessary-qualifier] False positive with enum/namespace merge #5664
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	f4db009
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65e85dce11318f0008cdd96c
😎 Deploy Preview	https://deploy-preview-8591--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f4db009. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test visitor-keys
• nx run types:build
• nx test utils
• nx test typescript-eslint
• nx test type-utils
• nx run repo-tools:postinstall-script
• nx test typescript-estree
• nx test rule-schema-to-typescript-types
• nx test scope-manager
• nx test repo-tools
• nx test parser
• nx test eslint-plugin-internal
• nx test ast-spec
• nx test utils --coverage=false
• nx test visitor-keys --coverage=false
• nx test type-utils --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test typescript-eslint --coverage=false
• nx test typescript-estree --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test repo-tools --coverage=false
• nx test scope-manager --coverage=false
• nx test ast-spec --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx run-many --target=typecheck --parallel
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (3ac824b) to head (f4db009).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8591      +/-   ##
==========================================
- Coverage   87.14%   87.14%   -0.01%     
==========================================
  Files         251      251              
  Lines       12272    12271       -1     
  Branches     3871     3871              
==========================================
- Hits        10694    10693       -1     
  Misses       1306     1306              
  Partials      272      272              

Flag	Coverage Δ
unittest	87.14% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...slint-plugin/src/rules/no-unnecessary-qualifier.ts	100.00% <100.00%> (ø)

[yeonjuan]

// If the symbol in scope is different, the qualifier is necessary.

According to the comment at line 89, if a symbol is not in scope, it should not be considered unnecessary. If any counterexample exits, please let me know.

[JoshuaKGoldberg]

This makes sense. I'm not super familiar with the the merging nuances of enums and namespaces, so leaving as 1 approval. Thanks as usual! 🙌