New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-eslint): apply ignores
to all extended configs passed to config
helper function
#8567
Conversation
…d to `config` helper function
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
...(config.files && { files: config.files }), | ||
...(config.ignores && { ignores: config.ignores }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignores
will overwrite ignores
from the extended config. I'm not sure if this is the desired behavior, but so far I've made it to match the behavior of files
. Any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overriding is correct.
Any local config should always override the extended config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8567 +/- ##
==========================================
- Coverage 87.84% 87.12% -0.72%
==========================================
Files 397 251 -146
Lines 13844 12268 -1576
Branches 4073 3868 -205
==========================================
- Hits 12161 10689 -1472
+ Misses 1381 1307 -74
+ Partials 302 272 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...(config.files && { files: config.files }), | ||
...(config.ignores && { ignores: config.ignores }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overriding is correct.
Any local config should always override the extended config
PR Checklist
ignores
whenextends
is provided. #8511Overview