-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(eslint-plugin): [no-misused-promises] add test cases for spread args #8493
test(eslint-plugin): [no-misused-promises] add test cases for spread args #8493
Conversation
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
if (anySignatureIsThenableType(checker, node, type)) { | ||
return true; | ||
} | ||
|
||
return false; | ||
return anySignatureIsThenableType(checker, node, type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense! reverting and resolving conflicts
aaca6ea
to
1cc86f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM!
Aside: since this PR doesn't make any bug fixes, I think we should rename it from fix(eslint-plugin): ...
to test(eslint-plugin): ...
. What do you think?
1cc86f3
to
e174685
Compare
f2f57de
into
typescript-eslint:main
PR Checklist
Overview
Implements the action items detailed in #5744 (comment).
Only functional change is to add test cases for the concern in the issue.