Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(eslint-plugin): [no-misused-promises] add test cases for spread args #8493

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Implements the action items detailed in #5744 (comment).

Only functional change is to add test cases for the concern in the issue.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e174685
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d8c92c9a943f000778f1de
😎 Deploy Preview https://deploy-preview-8493--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review February 16, 2024 15:45
Comment on lines 677 to 675

if (anySignatureIsThenableType(checker, node, type)) {
return true;
}

return false;
return anySignatureIsThenableType(checker, node, type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8534 is going to add support for unions. And it looks like it's going to make changes exactly on these very lines. So, to avoid merge conflicts, what do you think about reverting these changes in favor of #8534

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! reverting and resolving conflicts

@kirkwaiblinger kirkwaiblinger force-pushed the 5744-misused-promises-spread-args branch from aaca6ea to 1cc86f3 Compare February 23, 2024 15:53
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

Aside: since this PR doesn't make any bug fixes, I think we should rename it from fix(eslint-plugin): ... to test(eslint-plugin): ... . What do you think?

@kirkwaiblinger kirkwaiblinger force-pushed the 5744-misused-promises-spread-args branch from 1cc86f3 to e174685 Compare February 23, 2024 16:34
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [no-misused-promises] add test cases for spread args test(eslint-plugin): [no-misused-promises] add test cases for spread args Feb 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit f2f57de into typescript-eslint:main Feb 24, 2024
60 of 61 checks passed
@kirkwaiblinger kirkwaiblinger deleted the 5744-misused-promises-spread-args branch February 24, 2024 17:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-misused-promises] An array of promises passed with spread (...args) syntax is not checked
3 participants