Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): use mergeable interface for settings property (again) #8485

Merged
merged 2 commits into from Feb 16, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Feb 16, 2024

PR Checklist

Overview

It looks like #3556 got "undone" at some point - its now a type which can't be merged with; sadly I only noticed this after the next next major came out so I'll still need to use a type-cast 😞

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5e4ed5e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65cee0ab44e85c00086f766b
😎 Deploy Preview https://deploy-preview-8485--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91
Accessibility: 100
Best Practices: 92
SEO: 98
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Feb 16, 2024

@bradzacher bradzacher merged commit 9708659 into typescript-eslint:main Feb 16, 2024
64 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants