fix(eslint-plugin): [no-use-before-define] fix false positive type reference in as, satisfies

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-use-before-define] false positive in a mapped type within satisfies or as when ignoreTypeReferences: false #8451
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

I think the type reference should not be checked with isInInitializer.

/**
 * Checks whether or not a given reference is inside of the initializers of a given variable.
 *
 * @returns `true` in the following cases:
 * - var a = a
 * - var [a = a] = list
 * - var {a = a} = obj
 * - for (var a in a) {}
 * - for (var a of a) {}
 */
function isInInitializer(

This PR changes isInInitializer to be used only for value references.

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	c389d5e
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65d7613ef21854000898d6ca
😎 Deploy Preview	https://deploy-preview-8474--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 88 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c389d5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test visitor-keys
• nx run types:build
• nx run repo-tools:postinstall-script
• nx test eslint-plugin --coverage=false
• nx test typescript-estree
• nx test type-utils
• nx test utils
• nx test typescript-eslint
• nx test rule-schema-to-typescript-types
• nx test repo-tools
• nx test parser
• nx test scope-manager
• nx test eslint-plugin-internal
• nx run-many --target=lint --parallel
• nx test visitor-keys --coverage=false
• nx test ast-spec
• nx test typescript-eslint --coverage=false
• nx test type-utils --coverage=false
• nx test scope-manager --coverage=false
• nx test utils --coverage=false
• nx test typescript-estree --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test ast-spec --coverage=false
• nx test repo-tools --coverage=false
• nx test parser --coverage=false
• nx run-many --target=typecheck --parallel
• nx test eslint-plugin-internal --coverage=false
• nx run integration-tests:test
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (f825426) to head (c389d5e).
Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8474   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         250      250           
  Lines       12201    12202    +1     
  Branches     3852     3853    +1     
=======================================
+ Hits        10602    10603    +1     
  Misses       1332     1332           
  Partials      267      267           

Flag	Coverage Δ
unittest	86.89% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...es/eslint-plugin/src/rules/no-use-before-define.ts	95.19% <100.00%> (+0.04%)	⬆️

[JoshuaKGoldberg]

Looks good! A nice straightforward logic change that makes sense.

I think just requesting changes on the unit tests to have a bit more testing around both valid & invalid cases. But nothing architectural.

Co-authored-by: @auvred

[yeonjuan]

It looks like @typescript-eslint/internal/plugin-test-formatting is failing intermittently in the github action: an error occurred in explicit-function-return-type.test.ts:9, which is unrelated to this PR.

• https://github.com/typescript-eslint/typescript-eslint/actions/runs/7958920730/job/21724872046?pr=8474

[JoshuaKGoldberg]

It looks like @typescript-eslint/internal/plugin-test-formatting is failing intermittently in the github action

Yeah, sorry for the noise: #8373

[JoshuaKGoldberg]

LGTM, nice! Will defer to @auvred as we were both reviewing. 🙂

[auvred]