Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): update peer dep for parser #8441

Merged
merged 3 commits into from Feb 12, 2024
Merged

fix(eslint-plugin): update peer dep for parser #8441

merged 3 commits into from Feb 12, 2024

Conversation

timdorr
Copy link
Contributor

@timdorr timdorr commented Feb 12, 2024

This is breaking installing the latest plugin version.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @timdorr!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e9e4323
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65ca773daa3810000868a8c5
😎 Deploy Preview https://deploy-preview-8441--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@timdorr
Copy link
Contributor Author

timdorr commented Feb 12, 2024

BTW, I submitted this via VS Code Web, so I might be missing lots of important steps. Just wanted to get this PR in quickly, since it's breaking new installs. Feel free to discard and do your own thing! :)

@timdorr timdorr changed the title fix(eslint-plugin): Update peer dep for parser fix(eslint-plugin): update peer dep for parser Feb 12, 2024
Copy link

nx-cloud bot commented Feb 12, 2024

@timdorr
Copy link
Contributor Author

timdorr commented Feb 12, 2024

Thanks for the assist, @JoshuaKGoldberg!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 422791c into typescript-eslint:main Feb 12, 2024
59 checks passed
@JoshuaKGoldberg
Copy link
Member

Thanks for hopping on this! Probably one of the fastest community bug fixes we've ever seen. 😄

@timdorr
Copy link
Contributor Author

timdorr commented Feb 12, 2024

Thanks! I was lucky that I caught it because I was upgrading deps right in-between parser@7.0.0 and eslint-plugin@7.0.0 being published.

@timdorr timdorr deleted the peer-deps branch February 12, 2024 20:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants