fix(eslint-plugin): [ban-ts-comment] more accurate handling of multiline comments

[auvred]

PR Checklist

• Addresses an existing open issue: fixes Bug: [ban-ts-comment] incorrectly handles directives in multiline block comments #8368
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a108410
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65e9b1f31d90d40007b66f9e
😎 Deploy Preview	https://deploy-preview-8416--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 9 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a108410. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test typescript-eslint
• nx run types:build
• nx test utils
• nx test parser
• nx test type-utils
• nx run repo-tools:postinstall-script
• nx test visitor-keys
• nx test scope-manager
• nx test typescript-estree
• nx test rule-schema-to-typescript-types
• nx test eslint-plugin-internal
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test repo-tools
• nx test ast-spec
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx run-many --target=typecheck --parallel
• nx test rule-schema-to-typescript-types --coverage=false
• nx test visitor-keys --coverage=false
• nx test type-utils --coverage=false
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test typescript-eslint --coverage=false
• nx test repo-tools --coverage=false
• nx test parser --coverage=false
• nx test ast-spec --coverage=false
• nx run integration-tests:test
• nx run repo-tools:generate-configs
• nx test utils --coverage=false
• nx test scope-manager --coverage=false

---

Sent with 💌 from NxCloud.

[auvred]

Perhaps to be fully consistent with TypeScript's behavior, we should even check that this comment is in the begging of the file. Because // @ts-nocheck placed after some code is not a valid pragma. Sounds like a good followup, wdyt?

[JoshuaKGoldberg]

Yeah I'd +1 filing that as an issue.

[auvred]

Here it is - #8753

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (25e6518) to head (a108410).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8416      +/-   ##
==========================================
+ Coverage   87.21%   87.23%   +0.01%     
==========================================
  Files         251      251              
  Lines       12305    12316      +11     
  Branches     3880     3881       +1     
==========================================
+ Hits        10732    10744      +12     
+ Misses       1303     1302       -1     
  Partials      270      270              

Flag	Coverage Δ
unittest	87.23% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts	100.00% <100.00%> (+2.70%)	⬆️

[JoshuaKGoldberg]

🔥 Really nicely done!

This reminds me that microsoft/TypeScript#38370 is still waiting for a spec. Heh.

[JoshuaKGoldberg]

Yeah I'd +1 filing that as an issue.