Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [class-literal-property-style] ignore property assigned in constructor #8412

Merged
merged 2 commits into from Mar 18, 2024

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Feb 8, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 555aa63
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f82e57046ca7000899f8ec
😎 Deploy Preview https://deploy-preview-8412--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.35%. Comparing base (c0e3267) to head (555aa63).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8412      +/-   ##
==========================================
+ Coverage   87.21%   87.35%   +0.14%     
==========================================
  Files         251      253       +2     
  Lines       12315    12451     +136     
  Branches     3883     3918      +35     
==========================================
+ Hits        10740    10877     +137     
  Misses       1305     1305              
+ Partials      270      269       -1     
Flag Coverage Δ
unittest 87.35% <91.22%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/prefer-for-of.ts 100.00% <100.00%> (+7.35%) ⬆️
packages/eslint-plugin/src/util/isAssignee.ts 77.27% <77.27%> (ø)

... and 16 files with indirect coverage changes

@yeonjuan yeonjuan marked this pull request as ready for review February 13, 2024 13:52
@yeonjuan yeonjuan marked this pull request as draft February 20, 2024 15:42
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 🙌

This PR has two strategies that keep popping up: using a stack for scope, and static string values (#8323). I like it.

Woman in glasses at an old green-text-on-black-screen computer saying "Smarty Pants", then pushing up her glasses.

@JoshuaKGoldberg
Copy link
Member

Since it's Monday and we'll release soon, I'll just apply this myself. 👍

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Mar 18, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 04e32d6 into typescript-eslint:main Mar 18, 2024
58 of 59 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[class-literal-property-style] should not fix readonly to getter when assigned in ctor
2 participants