fix(eslint-plugin): [no-var-requires, no-require-imports] support template literal

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-var-requires, no-require-imports] support template literal strings for allow #8186
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	392b61d
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65e85d9ed526e20008dcb2e0
😎 Deploy Preview	https://deploy-preview-8408--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 392b61d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin
• nx test eslint-plugin --coverage=false
• nx test type-utils
• nx run types:build
• nx run repo-tools:postinstall-script
• nx test visitor-keys
• nx test typescript-eslint
• nx test scope-manager
• nx test utils
• nx test rule-schema-to-typescript-types
• nx test typescript-estree
• nx test parser
• nx test repo-tools
• nx test eslint-plugin-internal
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test utils --coverage=false
• nx test ast-spec
• nx test visitor-keys --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test scope-manager --coverage=false
• nx test typescript-estree --coverage=false
• nx test type-utils --coverage=false
• nx test typescript-eslint --coverage=false
• nx run-many --target=typecheck --parallel
• nx test repo-tools --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx test ast-spec --coverage=false
• nx run repo-tools:generate-configs
• nx run integration-tests:test

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.18%. Comparing base (3ac824b) to head (392b61d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8408      +/-   ##
==========================================
+ Coverage   87.14%   87.18%   +0.04%     
==========================================
  Files         251      251              
  Lines       12272    12279       +7     
  Branches     3871     3873       +2     
==========================================
+ Hits        10694    10706      +12     
+ Misses       1306     1304       -2     
+ Partials      272      269       -3     

Flag	Coverage Δ
unittest	87.18% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ages/eslint-plugin/src/rules/no-require-imports.ts	100.00% <100.00%> (+5.88%)	⬆️
...ackages/eslint-plugin/src/rules/no-var-requires.ts	100.00% <100.00%> (+6.66%)	⬆️

... and 1 file with indirect coverage changes

[JoshuaKGoldberg]

LGTM, thanks! 🙌

Note: there are other discussions around shared utilities around static things (#8323). Cross-linking there too.

@auvred @kirkwaiblinger you were active in those discussions too. I'd feel bad about not giving you a chance to look at this, if you have time. 😄

[auvred]

LGTM 🔥

---

Note: there are other discussions around shared utilities around static things (#8323). Cross-linking there too.

I think getStaticStringValue would be best friends with isStaticMemberAccessOfValue from #8323 😄

[auvred]

[non-actionable] getStaticStringValue internally checks for node.type === AST_NODE_TYPES.Literal || node.type === AST_NODE_TYPES.TemplateLiteral, so calling isStringOrTemplateLiteral seems a bit redundant here.. Although it returns modified values for non-string literals, but in this particular case (with the require call) I think it is fine, since passing non-string values to the require call would result in a TS error.

I'm fine with the current implementation, just leaving my thoughts here

[yeonjuan]

Hi @auvred Thanks for sharing your thoughts.
you're right, I added that condition because I was concerned about cases where non-strings(regex, number,..) are used in the arguments of the require() (probably no one writes code like that).
I thought it would be nice if TypeScript Eslint didn't throw an error when non-string value is used and a TS error occurs.

[JoshuaKGoldberg]

didn't throw an error when (invalid thing)

Aha, yes, that's a good thing to look out for in general. This is a very good + timely thread! 😄 Thanks - #8549