fix(eslint-plugin): [prefer-find] stop throwing type errors when converting symbols to numbers

[kirkwaiblinger]

PR Checklist

• Addresses an existing open issue: fixes Bug: [prefer-find] errors when trying to convert a Symbol value to a number #8386
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Adds exception handling around Number conversion.

[typescript-eslint]

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a8d2c21
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65c26afc4d9c7c00081d0e89
😎 Deploy Preview	https://deploy-preview-8390--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a8d2c21. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx run-many --target=lint --parallel

✅ Successfully ran 32 targets

• nx test eslint-plugin
• nx test utils
• nx run types:build
• nx test visitor-keys
• nx test type-utils
• nx test parser
• nx test typescript-eslint
• nx test scope-manager
• nx test eslint-plugin-tslint
• nx run repo-tools:postinstall-script
• nx test eslint-plugin --coverage=false
• nx test rule-schema-to-typescript-types
• nx test repo-tools
• nx test typescript-estree
• nx test eslint-plugin-internal
• nx test ast-spec
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test visitor-keys --coverage=false
• nx test utils --coverage=false
• nx run-many --target=typecheck --parallel
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx test ast-spec --coverage=false
• nx test scope-manager --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test typescript-eslint --coverage=false
• nx test repo-tools --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test type-utils --coverage=false
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[kirkwaiblinger]

This change just reverses the order of whether .at, or the (0), are inspected first. It's not needed for the fix, but I found it surprising that foo(Symbol.for('throws')) would throw, since it's not even an at call; it's just any old function. WIth this change, you have to actually have
x.at(Symbol.for('throws')) in order to trigger the faulty code.

[kirkwaiblinger]

this is all that's strictly necessary for the fix

[JoshuaKGoldberg]

LGTM! Just a suggestion on a refactor. WDYT?

Marking as 1 approval so this'll get merged before our next release by default.

[JoshuaKGoldberg]

[Refactor] I'm not a big fan of try/catch as a form of program control flow. It somewhat hides the intent of the code. Thrown errors are generally a sign of something truly breaking - IMO it's better to be intentional around code always working as expected.

Instead of generally catching all errors, how about checking if typeof value is 'symbol'?

[kirkwaiblinger]

yep, I was 50/50 on which way to go on this. Changed!

[JoshuaKGoldberg]

Btw, thanks for the fast followup!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1200b4c) 87.84% compared to head (a8d2c21) 87.05%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8390      +/-   ##
==========================================
- Coverage   87.84%   87.05%   -0.79%     
==========================================
  Files         396      250     -146     
  Lines       13809    12235    -1574     
  Branches     4064     3859     -205     
==========================================
- Hits        12130    10651    -1479     
+ Misses       1382     1317      -65     
+ Partials      297      267      -30     

Flag	Coverage Δ
unittest	87.05% <100.00%> (-0.79%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/eslint-plugin/src/rules/prefer-find.ts	100.00% <100.00%> (ø)

... and 146 files with indirect coverage changes

[JoshuaKGoldberg]

Great, thanks! 🙌

[JoshuaKGoldberg]

Lint failure is unrelated. #8373